From 64f9603e39aae2e3275e76b84ba4697007dc12f0 Mon Sep 17 00:00:00 2001
From: Jeff Emmett <jeffemmett@gmail.com>
Date: Sat, 21 Mar 2026 16:49:17 -0700
Subject: [PATCH] fix(spaces): stop module settings selects from polluting
 scope overrides
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Module settings selects (notebook-id, select types) shared the .scope-select
CSS class with actual data-scope selects, causing their values to be sent as
scopeOverrides — triggering "Invalid scope '' for rnotes" on save.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 shared/components/rstack-space-switcher.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/shared/components/rstack-space-switcher.ts b/shared/components/rstack-space-switcher.ts
index c184322..f4cec69 100644
--- a/shared/components/rstack-space-switcher.ts
+++ b/shared/components/rstack-space-switcher.ts
@@ -970,7 +970,7 @@ export class RStackSpaceSwitcher extends HTMLElement {
 					html += `
 					<div class="scope-row">
 						<span class="scope-label">Data scope:</span>
-						<select class="scope-select" data-mod-id="${m.id}">
+						<select class="scope-select data-scope-select" data-mod-id="${m.id}">
 							<option value="space" ${m.scoping.currentScope === "space" ? "selected" : ""}>Space</option>
 							<option value="global" ${m.scoping.currentScope === "global" ? "selected" : ""}>Global</option>
 						</select>
@@ -1068,7 +1068,7 @@ export class RStackSpaceSwitcher extends HTMLElement {
 
 				// Collect scope overrides
 				const scopeOverrides: Record<string, string> = {};
-				container.querySelectorAll(".scope-select").forEach((sel) => {
+				container.querySelectorAll(".data-scope-select").forEach((sel) => {
 					const el = sel as HTMLSelectElement;
 					scopeOverrides[el.dataset.modId!] = el.value;
 				});