jeffemmett
/
rspace-online
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(rinbox): handle IMAP socket errors to prevent server crash-loop 

ImapFlow clients were created without .on('error') handlers. Socket
timeouts emitted unhandled errors that crashed the entire process,
taking down all 32 modules. Added error handlers to all 3 ImapFlow
instantiation sites and a process-level uncaughtException/unhandledRejection
safety net.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Jeff Emmett 2026-04-02 13:50:45 -07:00
parent 14f7ccb090
commit 4b2592c27f
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
modules/rinbox/mod.ts
View File

@ -1112,6 +1112,7 @@ routes.post("/api/personal-inboxes", async (c) => {
auth: { user: imap_user, pass: imap_pass }, auth: { user: imap_user, pass: imap_pass },
logger: false, logger: false,
}); });
client.on('error', () => {}); // swallow — validation only
await client.connect(); await client.connect();
await client.logout(); await client.logout();
} catch (e: any) { } catch (e: any) {
@ -1454,6 +1455,9 @@ async function syncMailbox(mailbox: SyncableMailbox) {
tls: { rejectUnauthorized: IMAP_TLS_REJECT }, tls: { rejectUnauthorized: IMAP_TLS_REJECT },
logger: false, logger: false,
}); });
client.on('error', (err: Error) => {
console.error(`[Inbox] IMAP client error for ${mailbox.email}:`, err.message);
});
try { try {
await client.connect(); await client.connect();
@ -1704,6 +1708,9 @@ async function syncAgentMailbox(creds: AgentImapCreds) {
tls: { rejectUnauthorized: IMAP_TLS_REJECT }, tls: { rejectUnauthorized: IMAP_TLS_REJECT },
logger: false, logger: false,
}); });
client.on('error', (err: Error) => {
console.error(`[Inbox] Agent IMAP client error (${creds.email}):`, err.message);
});
try { try {
await client.connect(); await client.connect();

9
server/index.ts
View File

@ -103,6 +103,15 @@ import { SystemClock } from "./clock-service";
import type { ClockPayload } from "./clock-service"; import type { ClockPayload } from "./clock-service";
import { miRoutes } from "./mi-routes"; import { miRoutes } from "./mi-routes";
// ── Process-level error safety net (prevent crash on unhandled socket errors) ──
process.on('uncaughtException', (err) => {
console.error('[FATAL] Uncaught exception (swallowed):', err.message);
// Don't exit — keep the server running
});
process.on('unhandledRejection', (reason) => {
console.error('[FATAL] Unhandled rejection (swallowed):', reason);
});
// Register modules (order determines app-switcher menu position) // Register modules (order determines app-switcher menu position)
registerModule(canvasModule); registerModule(canvasModule);
registerModule(pubsModule); registerModule(pubsModule);