jeffemmett
/
rspace-online
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: PWA install banner uses root-domain cookie for cross-subdomain dismiss 

localStorage is per-subdomain so dismissing on demo.rspace.online didn't
persist to jeff.rspace.online. Now uses a .rspace.online cookie (10yr
max-age) so one dismiss covers all subdomains.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Jeff Emmett 2026-04-15 11:33:44 -04:00
parent a2dbf4533a
commit 0d5aeebd8e
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
server/shell.ts
View File

@ -398,14 +398,17 @@ export function renderShell(opts: ShellOptions): string {
}
// Install banner — browser only (not shown in installed PWA)
// Permanently dismissed once closed or installed (localStorage key persists)
// Permanently dismissed once closed or installed.
// Uses root-domain cookie so dismissal persists across all subdomains.
if (!isStandalone) {
const installDismissed = () => localStorage.getItem('rspace_install_dismissed') === '1';
const installDismissed = () => document.cookie.includes('rspace_install_dismissed=1');
const dismissInstall = () => {
const b = document.getElementById('pwa-install-banner');
if (b) b.style.display = 'none';
document.body.classList.remove('rspace-banner-visible');
localStorage.setItem('rspace_install_dismissed', '1');
const host = location.hostname;
const domainPart = host.includes('.') ? '; domain=.' + host.split('.').slice(-2).join('.') : '';
document.cookie = 'rspace_install_dismissed=1; path=/; max-age=315360000; SameSite=Lax' + domainPart;
};
window.addEventListener("beforeinstallprompt", (e) => {