From dcc140dca032532482c9a499dade4869143c865a Mon Sep 17 00:00:00 2001 From: DrummyFloyd Date: Mon, 12 May 2025 17:42:41 +0200 Subject: [PATCH 1/2] fix(oidc): remove trailling / needed but add manually depends on provider keycloack != authentik --- apps/backend/src/services/auth/providers/oauth.provider.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/backend/src/services/auth/providers/oauth.provider.ts b/apps/backend/src/services/auth/providers/oauth.provider.ts index 9ce6f278..30175238 100644 --- a/apps/backend/src/services/auth/providers/oauth.provider.ts +++ b/apps/backend/src/services/auth/providers/oauth.provider.ts @@ -60,7 +60,7 @@ export class OauthProvider implements ProvidersInterface { } async getToken(code: string): Promise { - const response = await fetch(`${this.tokenUrl}/`, { + const response = await fetch(`${this.tokenUrl}`, { method: 'POST', headers: { 'Content-Type': 'application/x-www-form-urlencoded', @@ -85,7 +85,7 @@ export class OauthProvider implements ProvidersInterface { } async getUser(access_token: string): Promise<{ email: string; id: string }> { - const response = await fetch(`${this.userInfoUrl}/`, { + const response = await fetch(`${this.userInfoUrl}`, { headers: { Authorization: `Bearer ${access_token}`, Accept: 'application/json', From cbc7d2bb65bcb37a41a1d25d23187ef5f3acd623 Mon Sep 17 00:00:00 2001 From: DrummyFloyd Date: Mon, 12 May 2025 17:43:24 +0200 Subject: [PATCH 2/2] fix(oidc): missing oidcGeneric on /auth --- apps/frontend/src/components/auth/register.tsx | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/apps/frontend/src/components/auth/register.tsx b/apps/frontend/src/components/auth/register.tsx index 0ac2f285..31669f0f 100644 --- a/apps/frontend/src/components/auth/register.tsx +++ b/apps/frontend/src/components/auth/register.tsx @@ -14,6 +14,7 @@ import { LoadingComponent } from '@gitroom/frontend/components/layout/loading'; import interClass from '@gitroom/react/helpers/inter.font'; import clsx from 'clsx'; import { GoogleProvider } from '@gitroom/frontend/components/auth/providers/google.provider'; +import { OauthProvider } from '@gitroom/frontend/components/auth/providers/oauth.provider'; import { useFireEvents } from '@gitroom/helpers/utils/use.fire.events'; import { useVariables } from '@gitroom/react/helpers/variable.context'; import { useTrack } from '@gitroom/react/helpers/use.track'; @@ -91,7 +92,8 @@ export function RegisterAfter({ token: string; provider: string; }) { - const { isGeneral, neynarClientId, billingEnabled } = useVariables(); + const { isGeneral, genericOauth, neynarClientId, billingEnabled } = + useVariables(); const [loading, setLoading] = useState(false); const router = useRouter(); const fireEvents = useFireEvents(); @@ -163,7 +165,11 @@ export function RegisterAfter({ ) : (
- + {genericOauth && isGeneral ? ( + + ) : ( + + )} {!!neynarClientId && } {billingEnabled && }