From 58211410d1b2c9aa2de471b0088f305e93a35a40 Mon Sep 17 00:00:00 2001
From: Nevo David <me@nevos.io>
Date: Mon, 14 Jul 2025 16:31:44 +0700
Subject: [PATCH] feat: better error messages

---
 .../src/database/prisma/media/media.service.ts             | 5 ++---
 libraries/nestjs-libraries/src/videos/video.manager.ts     | 7 +------
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/libraries/nestjs-libraries/src/database/prisma/media/media.service.ts b/libraries/nestjs-libraries/src/database/prisma/media/media.service.ts
index 5fb3fb6e..c6e63ef5 100644
--- a/libraries/nestjs-libraries/src/database/prisma/media/media.service.ts
+++ b/libraries/nestjs-libraries/src/database/prisma/media/media.service.ts
@@ -125,11 +125,10 @@ export class MediaService {
 
     // @ts-ignore
     const functionToCall = video.instance[functionName];
-    if (typeof functionToCall !== 'function') {
-      throw new Error(`Function ${functionName} not found on video instance`);
+    if (typeof functionToCall !== 'function' || this._videoManager.checkAvailableVideoFunction(functionToCall)) {
+      throw new HttpException(`Function ${functionName} not found on video instance`, 400);
     }
 
-    this._videoManager.checkAvailableVideoFunction(functionToCall);
     return functionToCall(body);
   }
 }
diff --git a/libraries/nestjs-libraries/src/videos/video.manager.ts b/libraries/nestjs-libraries/src/videos/video.manager.ts
index 2168300e..1be82140 100644
--- a/libraries/nestjs-libraries/src/videos/video.manager.ts
+++ b/libraries/nestjs-libraries/src/videos/video.manager.ts
@@ -24,12 +24,7 @@ export class VideoManager {
 
   checkAvailableVideoFunction(method: any) {
     const videoFunction = Reflect.getMetadata('video-function', method);
-    if (!videoFunction) {
-      throw new Error(
-        `Method ${method.name} is not a valid video function.`
-      );
-    }
-    return videoFunction;
+    return !videoFunction;
   }
 
   getVideoByName(