chore: remove unused ref (#203)

This commit is contained in:
Camila Sosa Morales 2023-04-05 15:55:47 -03:00 committed by GitHub
parent c1af8df24c
commit a4542d7442
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 156 additions and 164 deletions

View File

@ -156,8 +156,7 @@ export type ComboboxProps = {
error?: boolean; error?: boolean;
}; };
export const Combobox = forwardRef<HTMLInputElement, ComboboxProps>( export const Combobox: React.FC<ComboboxProps> = ({
({
items, items,
selectedValue = { value: '', label: '' }, selectedValue = { value: '', label: '' },
withAutocomplete = false, withAutocomplete = false,
@ -165,7 +164,7 @@ export const Combobox = forwardRef<HTMLInputElement, ComboboxProps>(
onChange, onChange,
onBlur, onBlur,
error = false, error = false,
}) => { }) => {
const [filteredItems, setFilteredItems] = useState<ComboboxItem[]>([]); const [filteredItems, setFilteredItems] = useState<ComboboxItem[]>([]);
const [autocompleteItems, setAutocompleteItems] = useState<ComboboxItem[]>( const [autocompleteItems, setAutocompleteItems] = useState<ComboboxItem[]>(
[] []
@ -267,16 +266,13 @@ export const Combobox = forwardRef<HTMLInputElement, ComboboxProps>(
) : ( ) : (
<> <>
{autocompleteItems.length > 0 && <span>Create new</span>} {autocompleteItems.length > 0 && <span>Create new</span>}
{autocompleteItems.map( {autocompleteItems.map((autocompleteOption: ComboboxItem) => (
(autocompleteOption: ComboboxItem) => (
<ComboboxOption <ComboboxOption
key={autocompleteOption.value} key={autocompleteOption.value}
option={autocompleteOption} option={autocompleteOption}
/> />
) ))}
)} {autocompleteItems.length > 0 && filteredItems.length > 0 && (
{autocompleteItems.length > 0 &&
filteredItems.length > 0 && (
<Separator css={{ mb: '$2' }} /> <Separator css={{ mb: '$2' }} />
)} )}
{filteredItems.map((option: ComboboxItem) => ( {filteredItems.map((option: ComboboxItem) => (
@ -290,7 +286,6 @@ export const Combobox = forwardRef<HTMLInputElement, ComboboxProps>(
)} )}
</ComboboxLib> </ComboboxLib>
); );
} };
);
Combobox.displayName = 'Combobox'; Combobox.displayName = 'Combobox';

View File

@ -134,8 +134,7 @@ export abstract class Form {
} }
); );
static readonly Combobox = forwardRef<HTMLInputElement, Form.ComboboxProps>( static readonly Combobox: React.FC<Form.ComboboxProps> = (props) => {
(props, ref) => {
const { const {
id, id,
validators, validators,
@ -166,7 +165,6 @@ export abstract class Form {
return ( return (
<Combobox <Combobox
ref={ref}
{...props} {...props}
onChange={handleComboboxChange} onChange={handleComboboxChange}
selectedValue={comboboxValue || ({} as ComboboxItem)} selectedValue={comboboxValue || ({} as ComboboxItem)}
@ -174,8 +172,7 @@ export abstract class Form {
error={validationEnabled && !isValid} error={validationEnabled && !isValid}
/> />
); );
} };
);
static readonly ColorPicker: React.FC<Form.ColorPickerProps> = ({ static readonly ColorPicker: React.FC<Form.ColorPickerProps> = ({
logo, logo,