From 64de5d735f8802ac13d55e98a49b0b2a3ea444ed Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E2=80=9Cchrisshank=E2=80=9D?= <chris.shank.23@gmail.com>
Date: Wed, 1 Jan 2025 15:13:09 -0800
Subject: [PATCH] more intl

---
 labs/intl-elements/intl-number.ts | 56 +++++++++++++++++++++----------
 website/canvas/intl-number.html   | 18 ++++++++++
 2 files changed, 56 insertions(+), 18 deletions(-)
 create mode 100644 website/canvas/intl-number.html

diff --git a/labs/intl-elements/intl-number.ts b/labs/intl-elements/intl-number.ts
index 9d343b5..8821b9f 100644
--- a/labs/intl-elements/intl-number.ts
+++ b/labs/intl-elements/intl-number.ts
@@ -20,8 +20,11 @@ export class IntlNumber extends FolkElement {
     }
   `;
 
+  // `lang` is a global attribute, should be navigate up the DOM tree to find it?
+  @property({ reflect: true }) locale: string | undefined;
+
   // Locale options
-  @property({ reflect: true }) localeMatcher: NumberFormatOptions['localeMatcher'] = 'best fit';
+  @property({ reflect: true }) localeMatcher: NumberFormatOptions['localeMatcher'];
 
   @property({ reflect: true }) numberingSystem: NumberFormatOptions['numberingSystem'];
 
@@ -36,11 +39,11 @@ export class IntlNumber extends FolkElement {
 
   @property({ reflect: true, type: Number }) maximumSignificantDigits: NumberFormatOptions['maximumSignificantDigits'];
 
-  @property({ reflect: true }) roundingPriority: NumberFormatOptions['roundingPriority'] = 'auto';
+  @property({ reflect: true }) roundingPriority: NumberFormatOptions['roundingPriority'];
 
   @property({ reflect: true, type: Number }) roundingIncrement: NumberFormatOptions['roundingIncrement'];
 
-  @property({ reflect: true }) roundingMode: NumberFormatOptions['roundingMode'] = 'halfExpand';
+  @property({ reflect: true }) roundingMode: NumberFormatOptions['roundingMode'];
 
   @property({ reflect: true }) trailingZeroDisplay: NumberFormatOptions['trailingZeroDisplay'];
 
@@ -50,24 +53,24 @@ export class IntlNumber extends FolkElement {
 
   @property({ reflect: true }) currency: NumberFormatOptions['currency'];
 
-  @property({ reflect: true }) currencyDisplay: NumberFormatOptions['currencyDisplay'] = 'symbol';
+  @property({ reflect: true }) currencyDisplay: NumberFormatOptions['currencyDisplay'];
 
-  @property({ reflect: true }) currencySign: NumberFormatOptions['currencySign'] = 'standard';
+  @property({ reflect: true }) currencySign: NumberFormatOptions['currencySign'];
 
-  @property({ reflect: true }) unit: string | undefined;
+  @property({ reflect: true }) unit: NumberFormatOptions['unit'];
 
-  @property({ reflect: true }) unitDisplay: 'short' | 'long' = 'short';
+  @property({ reflect: true }) unitDisplay: NumberFormatOptions['unitDisplay'];
 
   // Other options
-  @property({ reflect: true }) notation: NumberFormatOptions['notation'] = 'standard';
+  @property({ reflect: true }) notation: NumberFormatOptions['notation'];
 
-  @property({ reflect: true }) compactDisplay: NumberFormatOptions['compactDisplay'] = 'short';
+  @property({ reflect: true }) compactDisplay: NumberFormatOptions['compactDisplay'];
 
-  @property({ reflect: true }) useGrouping: NumberFormatOptions['useGrouping'] = undefined;
+  @property({ reflect: true }) useGrouping: NumberFormatOptions['useGrouping'];
 
-  @property({ reflect: true }) signDisplay: NumberFormatOptions['signDisplay'] = 'auto';
+  @property({ reflect: true }) signDisplay: NumberFormatOptions['signDisplay'];
 
-  #format!: Intl.NumberFormat;
+  #format: Intl.NumberFormat | undefined;
   #value: number = NaN;
   #slot = document.createElement('slot');
   #span = document.createElement('span');
@@ -85,7 +88,7 @@ export class IntlNumber extends FolkElement {
     return this.#span.textContent;
   }
 
-  protected override createRenderRoot(): HTMLElement | DocumentFragment {
+  override createRenderRoot(): HTMLElement | DocumentFragment {
     const root = super.createRenderRoot();
 
     this.#span.part.add('number');
@@ -99,9 +102,26 @@ export class IntlNumber extends FolkElement {
     return root;
   }
 
+  override connectedCallback(): void {
+    super.connectedCallback();
+
+    window.addEventListener('languagechange', this.#onLanguageChange);
+  }
+
+  override disconnectedCallback(): void {
+    super.disconnectedCallback();
+
+    window.removeEventListener('languagechange', this.#onLanguageChange);
+  }
+
+  #onLanguageChange = () => this.requestUpdate();
+
   override willUpdate(): void {
     // Any change to properties requires re-creating the formatter.
-    this.#format = new Intl.NumberFormat(undefined, {
+
+    // Default locale to navigator.language since it's the browsers language setting
+    // Passing undefined seems to reflect the OS's language setting.
+    this.#format = new Intl.NumberFormat(this.locale || navigator.language, {
       localeMatcher: this.localeMatcher,
       numberingSystem: this.numberingSystem,
 
@@ -132,11 +152,11 @@ export class IntlNumber extends FolkElement {
     this.#updateValue();
   }
 
-  #updateValue() {
-    if ((this.#value = NaN)) {
+  #updateValue = () => {
+    if (Number.isNaN(this.#value)) {
       this.#span.textContent = '';
-    } else {
+    } else if (this.#format) {
       this.#span.textContent = this.#format.format(this.#value);
     }
-  }
+  };
 }
diff --git a/website/canvas/intl-number.html b/website/canvas/intl-number.html
new file mode 100644
index 0000000..d5f17c8
--- /dev/null
+++ b/website/canvas/intl-number.html
@@ -0,0 +1,18 @@
+<!doctype html>
+<html lang="en">
+  <head>
+    <meta charset="UTF-8" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+    <title>Internationalized Number</title>
+    <style></style>
+  </head>
+  <body>
+    <intl-number maximumSignificantDigits="3">123456.789</intl-number>
+    <br />
+    <intl-number unit="liter">10</intl-number>
+    <br />
+    <script type="module">
+      import '@labs/standalone/intl-number.ts';
+    </script>
+  </body>
+</html>