From b1dc5868b2007f8802c9aa71d4ce5893646c6bc9 Mon Sep 17 00:00:00 2001
From: Kimberlee Johnson <hello@kimberlee.dev>
Date: Tue, 4 Jan 2022 15:01:06 -0800
Subject: [PATCH 1/3] First pass at creating a multipleWaiting state value and
 memoizing notification accordingly

---
 .../WaitingRoom/WaitingRoomNotification.js    | 102 +++++++++++-------
 custom/shared/contexts/WaitingRoomProvider.js |   3 +
 2 files changed, 66 insertions(+), 39 deletions(-)

diff --git a/custom/shared/components/WaitingRoom/WaitingRoomNotification.js b/custom/shared/components/WaitingRoom/WaitingRoomNotification.js
index 3dee756..5ccbc38 100644
--- a/custom/shared/components/WaitingRoom/WaitingRoomNotification.js
+++ b/custom/shared/components/WaitingRoom/WaitingRoomNotification.js
@@ -1,5 +1,4 @@
-import React, { useEffect, useState } from 'react';
-
+import React, { useCallback, useEffect, useMemo, useState } from 'react';
 import { useCallState } from '../../contexts/CallProvider';
 import { useWaitingRoom } from '../../contexts/WaitingRoomProvider';
 import { ReactComponent as IconWaiting } from '../../icons/add-person-lg.svg';
@@ -14,9 +13,70 @@ export const WaitingRoomNotification = () => {
     showModal,
     setShowModal,
     waitingParticipants,
+    multipleWaiting,
   } = useWaitingRoom();
   const [showNotification, setShowNotification] = useState(false);
 
+  /**
+   * Click handlers passed to render functions
+   */
+  const handleViewAllClick = useCallback(() => {
+    setShowModal(true);
+    setShowNotification(false);
+  }, [setShowModal]);
+
+  const handleAllowClick = useCallback(() => {
+    grantAccess(waitingParticipants[0].id);
+  }, [grantAccess, waitingParticipants]);
+
+  const handleDenyClick = useCallback(() => {
+    denyAccess(multipleWaiting ? 'all' : waitingParticipants[0].id);
+  }, [denyAccess, waitingParticipants, multipleWaiting]);
+
+  /**
+   * Render the full participant waiting list
+   */
+  const showMultipleParticipants = useMemo(() => {
+    return (
+      <CardBody>
+        <p>
+          <strong>{waitingParticipants.length}</strong> people would like to
+          join the call
+        </p>
+        <CardFooter>
+          <Button onClick={handleViewAllClick} size="small" variant="success">
+            View all
+          </Button>
+          <Button onClick={handleDenyClick} size="small" variant="warning">
+            Deny all
+          </Button>
+        </CardFooter>
+      </CardBody>
+    );
+  }, [waitingParticipants, handleDenyClick, handleViewAllClick]);
+
+  /**
+   * Render the single waiting participant
+   */
+  const showSingleParticipant = useMemo(() => {
+    return (
+      <CardBody>
+        <p>
+          <strong>{waitingParticipants[0]?.name}</strong> would like to join the
+          call
+        </p>
+        <CardFooter>
+          <Button onClick={handleAllowClick} size="small" variant="success">
+            Allow
+          </Button>
+          <Button onClick={handleDenyClick} size="small" variant="warning">
+            Deny
+          </Button>
+        </CardFooter>
+      </CardBody>
+    );
+  }, [waitingParticipants, handleAllowClick, handleDenyClick]);
+
   /**
    * Show notification when waiting participants change.
    */
@@ -47,48 +107,12 @@ export const WaitingRoomNotification = () => {
 
   if (!showNotification || waitingParticipants.length === 0) return null;
 
-  const hasMultiplePeopleWaiting = waitingParticipants.length > 1;
-
-  const handleViewAllClick = () => {
-    setShowModal(true);
-    setShowNotification(false);
-  };
-  const handleAllowClick = () => {
-    grantAccess(waitingParticipants[0].id);
-  };
-  const handleDenyClick = () => {
-    denyAccess(hasMultiplePeopleWaiting ? 'all' : waitingParticipants[0].id);
-  };
-
   return (
     <Card className="waiting-room-notification">
       <aside>
         <IconWaiting />
       </aside>
-      <CardBody>
-        <strong>
-          {hasMultiplePeopleWaiting
-            ? waitingParticipants.length
-            : waitingParticipants[0].name}
-        </strong>
-        {hasMultiplePeopleWaiting
-          ? ` people would like to join the call`
-          : ` would like to join the call`}
-        <CardFooter>
-          {hasMultiplePeopleWaiting ? (
-            <Button onClick={handleViewAllClick} size="small" variant="success">
-              View all
-            </Button>
-          ) : (
-            <Button onClick={handleAllowClick} size="small" variant="success">
-              Allow
-            </Button>
-          )}
-          <Button onClick={handleDenyClick} size="small" variant="warning">
-            {hasMultiplePeopleWaiting ? 'Deny All' : 'Deny'}
-          </Button>
-        </CardFooter>
-      </CardBody>
+      {multipleWaiting ? showMultipleParticipants : showSingleParticipant}
       <style jsx>{`
         :global(.card.waiting-room-notification) {
           position: absolute;
diff --git a/custom/shared/contexts/WaitingRoomProvider.js b/custom/shared/contexts/WaitingRoomProvider.js
index 978036a..b99ab51 100644
--- a/custom/shared/contexts/WaitingRoomProvider.js
+++ b/custom/shared/contexts/WaitingRoomProvider.js
@@ -13,6 +13,7 @@ const WaitingRoomContext = createContext(null);
 export const WaitingRoomProvider = ({ children }) => {
   const { callObject } = useCallState();
   const [waitingParticipants, setWaitingParticipants] = useState([]);
+  const [multipleWaiting, setMultipleWaiting] = useState();
   const [showModal, setShowModal] = useState(false);
 
   const handleWaitingParticipantEvent = useCallback(() => {
@@ -31,6 +32,7 @@ export const WaitingRoomProvider = ({ children }) => {
         };
       })
     );
+    setMultipleWaiting(waiting.length > 1);
   }, [callObject]);
 
   useEffect(() => {
@@ -97,6 +99,7 @@ export const WaitingRoomProvider = ({ children }) => {
         setShowModal,
         showModal,
         waitingParticipants,
+        multipleWaiting,
       }}
     >
       {children}

From 0fcb3ce455224b176e93a7759024b2e75d2b1849 Mon Sep 17 00:00:00 2001
From: Kimberlee Johnson <hello@kimberlee.dev>
Date: Tue, 4 Jan 2022 15:38:49 -0800
Subject: [PATCH 2/3] Memoized Haircheck.js waiting message

---
 .../shared/components/HairCheck/HairCheck.js  | 78 +++++++++++--------
 1 file changed, 44 insertions(+), 34 deletions(-)

diff --git a/custom/shared/components/HairCheck/HairCheck.js b/custom/shared/components/HairCheck/HairCheck.js
index 0b1fa0f..fbb65aa 100644
--- a/custom/shared/components/HairCheck/HairCheck.js
+++ b/custom/shared/components/HairCheck/HairCheck.js
@@ -32,8 +32,13 @@ import { useDeepCompareMemo } from 'use-deep-compare';
 export const HairCheck = () => {
   const { callObject, join } = useCallState();
   const { localParticipant } = useParticipants();
-  const { deviceState, camError, micError, isCamMuted, isMicMuted } =
-    useMediaDevices();
+  const {
+    deviceState,
+    camError,
+    micError,
+    isCamMuted,
+    isMicMuted,
+  } = useMediaDevices();
   const { openModal } = useUIState();
   const [waiting, setWaiting] = useState(false);
   const [joining, setJoining] = useState(false);
@@ -95,10 +100,9 @@ export const HairCheck = () => {
     [localParticipant]
   );
 
-  const isLoading = useMemo(
-    () => deviceState === DEVICE_STATE_LOADING,
-    [deviceState]
-  );
+  const isLoading = useMemo(() => deviceState === DEVICE_STATE_LOADING, [
+    deviceState,
+  ]);
 
   const hasError = useMemo(() => {
     if (
@@ -127,6 +131,39 @@ export const HairCheck = () => {
     }
   }, [camError]);
 
+  const showWaitingMessage = useMemo(() => {
+    return (
+      <div className="waiting">
+        <Loader />
+        {denied ? (
+          <span>Call owner denied request</span>
+        ) : (
+          <span>Waiting for host to grant access</span>
+        )}
+      </div>
+    );
+  }, [denied]);
+
+  const showUsernameInput = useMemo(() => {
+    return (
+      <>
+        <TextInput
+          placeholder="Enter display name"
+          variant="dark"
+          disabled={joining}
+          value={userName}
+          onChange={(e) => setUserName(e.target.value)}
+        />
+        <Button
+          disabled={joining || userName.length < 3}
+          onClick={() => joinCall(userName)}
+        >
+          Join call
+        </Button>
+      </>
+    );
+  }, [userName, joinCall, joining, setUserName]);
+
   return (
     <>
       <main className="haircheck">
@@ -174,34 +211,7 @@ export const HairCheck = () => {
             </div>
             {tileMemo}
           </div>
-          <footer>
-            {waiting ? (
-              <div className="waiting">
-                <Loader />
-                {denied ? (
-                  <span>Call owner denied request</span>
-                ) : (
-                  <span>Waiting for host to grant access</span>
-                )}
-              </div>
-            ) : (
-              <>
-                <TextInput
-                  placeholder="Enter display name"
-                  variant="dark"
-                  disabled={joining}
-                  value={userName}
-                  onChange={(e) => setUserName(e.target.value)}
-                />
-                <Button
-                  disabled={joining || userName.length < 3}
-                  onClick={() => joinCall(userName)}
-                >
-                  Join call
-                </Button>
-              </>
-            )}
-          </footer>
+          <footer>{waiting ? showWaitingMessage : showUsernameInput}</footer>
         </div>
 
         <style jsx>{`

From abedd0729169aa75c9911e1702f6f4388cf266e0 Mon Sep 17 00:00:00 2001
From: Kimberlee Johnson <hello@kimberlee.dev>
Date: Wed, 5 Jan 2022 16:10:44 -0800
Subject: [PATCH 3/3] Adding memo for multipleWaiting and fixing styling

---
 .../shared/components/HairCheck/HairCheck.js  | 21 ++++++++++---------
 custom/shared/contexts/WaitingRoomProvider.js |  7 +++++--
 2 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/custom/shared/components/HairCheck/HairCheck.js b/custom/shared/components/HairCheck/HairCheck.js
index fbb65aa..c57c960 100644
--- a/custom/shared/components/HairCheck/HairCheck.js
+++ b/custom/shared/components/HairCheck/HairCheck.js
@@ -140,6 +140,17 @@ export const HairCheck = () => {
         ) : (
           <span>Waiting for host to grant access</span>
         )}
+        <style jsx>{`
+          .waiting {
+            display: flex;
+            flex-direction: column;
+            align-items: center;
+          }
+
+          .waiting span {
+            margin-left: var(--spacing-xxs);
+          }
+        `}</style>
       </div>
     );
   }, [denied]);
@@ -329,16 +340,6 @@ export const HairCheck = () => {
             grid-column-gap: var(--spacing-xs);
           }
 
-          .waiting {
-            display: flex;
-            align-items: center;
-            justify-content: center;
-          }
-
-          .waiting span {
-            margin-left: var(--spacing-xxs);
-          }
-
           .logo {
             position: absolute;
             top: var(--spacing-sm);
diff --git a/custom/shared/contexts/WaitingRoomProvider.js b/custom/shared/contexts/WaitingRoomProvider.js
index b99ab51..f6498de 100644
--- a/custom/shared/contexts/WaitingRoomProvider.js
+++ b/custom/shared/contexts/WaitingRoomProvider.js
@@ -3,6 +3,7 @@ import React, {
   useCallback,
   useContext,
   useEffect,
+  useMemo,
   useState,
 } from 'react';
 import PropTypes from 'prop-types';
@@ -13,7 +14,6 @@ const WaitingRoomContext = createContext(null);
 export const WaitingRoomProvider = ({ children }) => {
   const { callObject } = useCallState();
   const [waitingParticipants, setWaitingParticipants] = useState([]);
-  const [multipleWaiting, setMultipleWaiting] = useState();
   const [showModal, setShowModal] = useState(false);
 
   const handleWaitingParticipantEvent = useCallback(() => {
@@ -32,9 +32,12 @@ export const WaitingRoomProvider = ({ children }) => {
         };
       })
     );
-    setMultipleWaiting(waiting.length > 1);
   }, [callObject]);
 
+  const multipleWaiting = useMemo(() => waitingParticipants.length > 1, [
+    waitingParticipants,
+  ]);
+
   useEffect(() => {
     if (waitingParticipants.length === 0) {
       setShowModal(false);