528 lines
18 KiB
TypeScript
528 lines
18 KiB
TypeScript
/**
|
|
* Worker tests for Board Permissions handlers
|
|
*
|
|
* Tests the permission system including:
|
|
* - Global admin checks
|
|
* - Protected board access
|
|
* - Access token validation
|
|
* - Permission CRUD operations
|
|
*/
|
|
|
|
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import {
|
|
handleGetPermission,
|
|
handleListPermissions,
|
|
handleGrantPermission,
|
|
handleRevokePermission,
|
|
handleUpdateBoard,
|
|
handleCreateAccessToken,
|
|
handleListAccessTokens,
|
|
handleRevokeAccessToken,
|
|
handleGetGlobalAdminStatus,
|
|
handleGetBoardInfo,
|
|
handleListEditors,
|
|
} from '../../worker/boardPermissions'
|
|
import type { Environment } from '../../worker/types'
|
|
|
|
// Mock D1 database with configurable responses
|
|
function createMockD1() {
|
|
const mockResults: Map<string, unknown> = new Map()
|
|
|
|
const mockDb = {
|
|
prepare: vi.fn((sql: string) => ({
|
|
bind: vi.fn((...args: unknown[]) => ({
|
|
first: vi.fn(async <T>(): Promise<T | null> => {
|
|
const key = `first:${sql}:${JSON.stringify(args)}`
|
|
if (mockResults.has(key)) {
|
|
return mockResults.get(key) as T
|
|
}
|
|
// Check for pattern matches
|
|
for (const [k, v] of mockResults.entries()) {
|
|
if (k.startsWith('first:') && sql.includes(k.split(':')[1])) {
|
|
return v as T
|
|
}
|
|
}
|
|
return null
|
|
}),
|
|
all: vi.fn(async <T>(): Promise<{ results: T[] }> => {
|
|
const key = `all:${sql}`
|
|
return { results: (mockResults.get(key) as T[]) ?? [] }
|
|
}),
|
|
run: vi.fn(async () => ({ success: true })),
|
|
})),
|
|
first: vi.fn(async () => null),
|
|
all: vi.fn(async () => ({ results: [] })),
|
|
run: vi.fn(async () => ({ success: true })),
|
|
})),
|
|
// Helper to set mock return values
|
|
__setMockResult: (key: string, value: unknown) => {
|
|
mockResults.set(key, value)
|
|
},
|
|
__clearMocks: () => {
|
|
mockResults.clear()
|
|
},
|
|
}
|
|
|
|
return mockDb
|
|
}
|
|
|
|
// Create mock environment
|
|
function createMockEnv(overrides: Partial<Environment> = {}): Environment {
|
|
return {
|
|
TLDRAW_BUCKET: {} as R2Bucket,
|
|
BOARD_BACKUPS_BUCKET: {} as R2Bucket,
|
|
AUTOMERGE_DURABLE_OBJECT: {} as DurableObjectNamespace,
|
|
DAILY_API_KEY: 'mock-daily-key',
|
|
DAILY_DOMAIN: 'mock.daily.co',
|
|
CRYPTID_DB: createMockD1() as unknown as D1Database,
|
|
RESEND_API_KEY: 'mock-resend-key',
|
|
APP_URL: 'https://test.example.com',
|
|
...overrides,
|
|
}
|
|
}
|
|
|
|
// Create mock request
|
|
function createMockRequest(
|
|
url: string,
|
|
options: RequestInit & { publicKey?: string } = {}
|
|
): Request {
|
|
const { publicKey, ...requestOptions } = options
|
|
const headers = new Headers(requestOptions.headers)
|
|
headers.set('Content-Type', 'application/json')
|
|
if (publicKey) {
|
|
headers.set('X-CryptID-PublicKey', publicKey)
|
|
}
|
|
return new Request(url, {
|
|
method: 'GET',
|
|
...requestOptions,
|
|
headers,
|
|
})
|
|
}
|
|
|
|
describe('handleGetPermission', () => {
|
|
let env: Environment
|
|
|
|
beforeEach(() => {
|
|
env = createMockEnv()
|
|
})
|
|
|
|
it('returns view permission when no database configured', async () => {
|
|
const envWithoutDb = createMockEnv({ CRYPTID_DB: undefined })
|
|
const request = createMockRequest('https://test.com/boards/test-board/permission')
|
|
const response = await handleGetPermission('test-board', request, envWithoutDb)
|
|
const data = await response.json() as { permission: string }
|
|
|
|
expect(data.permission).toBe('view')
|
|
})
|
|
|
|
it('returns edit permission for non-existent board (new permission model)', async () => {
|
|
const request = createMockRequest('https://test.com/boards/new-board/permission')
|
|
const response = await handleGetPermission('new-board', request, env)
|
|
const data = await response.json() as { permission: string; boardExists: boolean }
|
|
|
|
expect(data.permission).toBe('edit')
|
|
expect(data.boardExists).toBe(false)
|
|
})
|
|
|
|
it('returns edit permission for unprotected board', async () => {
|
|
const request = createMockRequest('https://test.com/boards/test-board/permission')
|
|
const response = await handleGetPermission('test-board', request, env)
|
|
const data = await response.json() as { permission: string }
|
|
|
|
// Default is edit for non-existent/unprotected boards
|
|
expect(data.permission).toBe('edit')
|
|
})
|
|
})
|
|
|
|
describe('handleListPermissions', () => {
|
|
let env: Environment
|
|
|
|
beforeEach(() => {
|
|
env = createMockEnv()
|
|
})
|
|
|
|
it('returns error when database not configured', async () => {
|
|
const envWithoutDb = createMockEnv({ CRYPTID_DB: undefined })
|
|
const request = createMockRequest('https://test.com/boards/test-board/permissions')
|
|
const response = await handleListPermissions('test-board', request, envWithoutDb)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(503)
|
|
expect(data.error).toBe('Database not configured')
|
|
})
|
|
|
|
it('returns 401 when not authenticated', async () => {
|
|
const request = createMockRequest('https://test.com/boards/test-board/permissions')
|
|
const response = await handleListPermissions('test-board', request, env)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(401)
|
|
expect(data.error).toBe('Authentication required')
|
|
})
|
|
|
|
it('returns 401 for invalid credentials', async () => {
|
|
const request = createMockRequest('https://test.com/boards/test-board/permissions', {
|
|
publicKey: 'invalid-key',
|
|
})
|
|
const response = await handleListPermissions('test-board', request, env)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(401)
|
|
expect(data.error).toBe('Invalid credentials')
|
|
})
|
|
})
|
|
|
|
describe('handleGrantPermission', () => {
|
|
let env: Environment
|
|
|
|
beforeEach(() => {
|
|
env = createMockEnv()
|
|
})
|
|
|
|
it('returns error when database not configured', async () => {
|
|
const envWithoutDb = createMockEnv({ CRYPTID_DB: undefined })
|
|
const request = createMockRequest('https://test.com/boards/test-board/permissions', {
|
|
method: 'POST',
|
|
body: JSON.stringify({ userId: 'user-123', permission: 'edit' }),
|
|
})
|
|
const response = await handleGrantPermission('test-board', request, envWithoutDb)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(503)
|
|
expect(data.error).toBe('Database not configured')
|
|
})
|
|
|
|
it('returns 401 when not authenticated', async () => {
|
|
const request = createMockRequest('https://test.com/boards/test-board/permissions', {
|
|
method: 'POST',
|
|
body: JSON.stringify({ userId: 'user-123', permission: 'edit' }),
|
|
})
|
|
const response = await handleGrantPermission('test-board', request, env)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(401)
|
|
expect(data.error).toBe('Authentication required')
|
|
})
|
|
|
|
it('returns 401 for invalid credentials', async () => {
|
|
const request = createMockRequest('https://test.com/boards/test-board/permissions', {
|
|
method: 'POST',
|
|
publicKey: 'invalid-key',
|
|
body: JSON.stringify({ userId: 'user-123', permission: 'edit' }),
|
|
})
|
|
const response = await handleGrantPermission('test-board', request, env)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(401)
|
|
expect(data.error).toBe('Invalid credentials')
|
|
})
|
|
})
|
|
|
|
describe('handleRevokePermission', () => {
|
|
let env: Environment
|
|
|
|
beforeEach(() => {
|
|
env = createMockEnv()
|
|
})
|
|
|
|
it('returns error when database not configured', async () => {
|
|
const envWithoutDb = createMockEnv({ CRYPTID_DB: undefined })
|
|
const request = createMockRequest('https://test.com/boards/test-board/permissions/user-123', {
|
|
method: 'DELETE',
|
|
})
|
|
const response = await handleRevokePermission('test-board', 'user-123', request, envWithoutDb)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(503)
|
|
expect(data.error).toBe('Database not configured')
|
|
})
|
|
|
|
it('returns 401 when not authenticated', async () => {
|
|
const request = createMockRequest('https://test.com/boards/test-board/permissions/user-123', {
|
|
method: 'DELETE',
|
|
})
|
|
const response = await handleRevokePermission('test-board', 'user-123', request, env)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(401)
|
|
expect(data.error).toBe('Authentication required')
|
|
})
|
|
})
|
|
|
|
describe('handleUpdateBoard', () => {
|
|
let env: Environment
|
|
|
|
beforeEach(() => {
|
|
env = createMockEnv()
|
|
})
|
|
|
|
it('returns error when database not configured', async () => {
|
|
const envWithoutDb = createMockEnv({ CRYPTID_DB: undefined })
|
|
const request = createMockRequest('https://test.com/boards/test-board', {
|
|
method: 'PATCH',
|
|
body: JSON.stringify({ name: 'New Name' }),
|
|
})
|
|
const response = await handleUpdateBoard('test-board', request, envWithoutDb)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(503)
|
|
expect(data.error).toBe('Database not configured')
|
|
})
|
|
|
|
it('returns 401 when not authenticated', async () => {
|
|
const request = createMockRequest('https://test.com/boards/test-board', {
|
|
method: 'PATCH',
|
|
body: JSON.stringify({ name: 'New Name' }),
|
|
})
|
|
const response = await handleUpdateBoard('test-board', request, env)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(401)
|
|
expect(data.error).toBe('Authentication required')
|
|
})
|
|
})
|
|
|
|
describe('handleCreateAccessToken', () => {
|
|
let env: Environment
|
|
|
|
beforeEach(() => {
|
|
env = createMockEnv()
|
|
})
|
|
|
|
it('returns error when database not configured', async () => {
|
|
const envWithoutDb = createMockEnv({ CRYPTID_DB: undefined })
|
|
const request = createMockRequest('https://test.com/boards/test-board/access-tokens', {
|
|
method: 'POST',
|
|
body: JSON.stringify({ permission: 'edit' }),
|
|
})
|
|
const response = await handleCreateAccessToken('test-board', request, envWithoutDb)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(503)
|
|
expect(data.error).toBe('Database not configured')
|
|
})
|
|
|
|
it('returns 401 when not authenticated', async () => {
|
|
const request = createMockRequest('https://test.com/boards/test-board/access-tokens', {
|
|
method: 'POST',
|
|
body: JSON.stringify({ permission: 'edit' }),
|
|
})
|
|
const response = await handleCreateAccessToken('test-board', request, env)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(401)
|
|
expect(data.error).toBe('Authentication required')
|
|
})
|
|
})
|
|
|
|
describe('handleListAccessTokens', () => {
|
|
let env: Environment
|
|
|
|
beforeEach(() => {
|
|
env = createMockEnv()
|
|
})
|
|
|
|
it('returns error when database not configured', async () => {
|
|
const envWithoutDb = createMockEnv({ CRYPTID_DB: undefined })
|
|
const request = createMockRequest('https://test.com/boards/test-board/access-tokens')
|
|
const response = await handleListAccessTokens('test-board', request, envWithoutDb)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(503)
|
|
expect(data.error).toBe('Database not configured')
|
|
})
|
|
|
|
it('returns 401 when not authenticated', async () => {
|
|
const request = createMockRequest('https://test.com/boards/test-board/access-tokens')
|
|
const response = await handleListAccessTokens('test-board', request, env)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(401)
|
|
expect(data.error).toBe('Authentication required')
|
|
})
|
|
})
|
|
|
|
describe('handleRevokeAccessToken', () => {
|
|
let env: Environment
|
|
|
|
beforeEach(() => {
|
|
env = createMockEnv()
|
|
})
|
|
|
|
it('returns error when database not configured', async () => {
|
|
const envWithoutDb = createMockEnv({ CRYPTID_DB: undefined })
|
|
const request = createMockRequest('https://test.com/boards/test-board/access-tokens/token-123', {
|
|
method: 'DELETE',
|
|
})
|
|
const response = await handleRevokeAccessToken('test-board', 'token-123', request, envWithoutDb)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(503)
|
|
expect(data.error).toBe('Database not configured')
|
|
})
|
|
|
|
it('returns 401 when not authenticated', async () => {
|
|
const request = createMockRequest('https://test.com/boards/test-board/access-tokens/token-123', {
|
|
method: 'DELETE',
|
|
})
|
|
const response = await handleRevokeAccessToken('test-board', 'token-123', request, env)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(401)
|
|
expect(data.error).toBe('Authentication required')
|
|
})
|
|
})
|
|
|
|
describe('handleGetGlobalAdminStatus', () => {
|
|
let env: Environment
|
|
|
|
beforeEach(() => {
|
|
env = createMockEnv()
|
|
})
|
|
|
|
it('returns false when no database configured', async () => {
|
|
const envWithoutDb = createMockEnv({ CRYPTID_DB: undefined })
|
|
const request = createMockRequest('https://test.com/auth/global-admin-status')
|
|
const response = await handleGetGlobalAdminStatus(request, envWithoutDb)
|
|
const data = await response.json() as { isGlobalAdmin: boolean }
|
|
|
|
expect(data.isGlobalAdmin).toBe(false)
|
|
})
|
|
|
|
it('returns false when not authenticated', async () => {
|
|
const request = createMockRequest('https://test.com/auth/global-admin-status')
|
|
const response = await handleGetGlobalAdminStatus(request, env)
|
|
const data = await response.json() as { isGlobalAdmin: boolean }
|
|
|
|
expect(data.isGlobalAdmin).toBe(false)
|
|
})
|
|
|
|
it('returns false for invalid public key', async () => {
|
|
const request = createMockRequest('https://test.com/auth/global-admin-status', {
|
|
publicKey: 'invalid-key',
|
|
})
|
|
const response = await handleGetGlobalAdminStatus(request, env)
|
|
const data = await response.json() as { isGlobalAdmin: boolean }
|
|
|
|
expect(data.isGlobalAdmin).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe('handleGetBoardInfo', () => {
|
|
let env: Environment
|
|
|
|
beforeEach(() => {
|
|
env = createMockEnv()
|
|
})
|
|
|
|
it('returns null board when no database configured', async () => {
|
|
const envWithoutDb = createMockEnv({ CRYPTID_DB: undefined })
|
|
const request = createMockRequest('https://test.com/boards/test-board/info')
|
|
const response = await handleGetBoardInfo('test-board', request, envWithoutDb)
|
|
const data = await response.json() as { board: null; isProtected: boolean }
|
|
|
|
expect(data.board).toBeNull()
|
|
expect(data.isProtected).toBe(false)
|
|
})
|
|
|
|
it('returns null for non-existent board', async () => {
|
|
const request = createMockRequest('https://test.com/boards/non-existent/info')
|
|
const response = await handleGetBoardInfo('non-existent', request, env)
|
|
const data = await response.json() as { board: null; isProtected: boolean }
|
|
|
|
expect(data.board).toBeNull()
|
|
expect(data.isProtected).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe('handleListEditors', () => {
|
|
let env: Environment
|
|
|
|
beforeEach(() => {
|
|
env = createMockEnv()
|
|
})
|
|
|
|
it('returns error when database not configured', async () => {
|
|
const envWithoutDb = createMockEnv({ CRYPTID_DB: undefined })
|
|
const request = createMockRequest('https://test.com/boards/test-board/editors')
|
|
const response = await handleListEditors('test-board', request, envWithoutDb)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(503)
|
|
expect(data.error).toBe('Database not configured')
|
|
})
|
|
|
|
it('returns 401 when not authenticated', async () => {
|
|
const request = createMockRequest('https://test.com/boards/test-board/editors')
|
|
const response = await handleListEditors('test-board', request, env)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(401)
|
|
expect(data.error).toBe('Authentication required')
|
|
})
|
|
|
|
it('returns 401 for invalid credentials', async () => {
|
|
const request = createMockRequest('https://test.com/boards/test-board/editors', {
|
|
publicKey: 'invalid-key',
|
|
})
|
|
const response = await handleListEditors('test-board', request, env)
|
|
const data = await response.json() as { error: string }
|
|
|
|
expect(response.status).toBe(401)
|
|
expect(data.error).toBe('Invalid credentials')
|
|
})
|
|
})
|
|
|
|
describe('Permission Model Logic', () => {
|
|
let env: Environment
|
|
|
|
beforeEach(() => {
|
|
env = createMockEnv()
|
|
})
|
|
|
|
it('anonymous users get edit access on non-existent boards', async () => {
|
|
const request = createMockRequest('https://test.com/boards/brand-new-board/permission')
|
|
const response = await handleGetPermission('brand-new-board', request, env)
|
|
const data = await response.json() as { permission: string; boardExists: boolean }
|
|
|
|
expect(data.permission).toBe('edit')
|
|
expect(data.boardExists).toBe(false)
|
|
})
|
|
|
|
it('returns view permission when database unavailable (secure default)', async () => {
|
|
const envWithoutDb = createMockEnv({ CRYPTID_DB: undefined })
|
|
const request = createMockRequest('https://test.com/boards/any-board/permission')
|
|
const response = await handleGetPermission('any-board', request, envWithoutDb)
|
|
const data = await response.json() as { permission: string }
|
|
|
|
expect(data.permission).toBe('view')
|
|
})
|
|
})
|
|
|
|
describe('Access Token Security', () => {
|
|
let env: Environment
|
|
|
|
beforeEach(() => {
|
|
env = createMockEnv()
|
|
})
|
|
|
|
it('rejects admin permission level for access tokens', async () => {
|
|
// Access tokens should only allow view/edit, not admin
|
|
// This test verifies the security model
|
|
const request = createMockRequest('https://test.com/boards/test-board/access-tokens', {
|
|
method: 'POST',
|
|
publicKey: 'valid-admin-key',
|
|
body: JSON.stringify({ permission: 'admin' }),
|
|
})
|
|
|
|
// Even if authenticated, admin tokens should be rejected
|
|
// (the actual rejection happens after auth check, so we'd get 401 first with our mock)
|
|
const response = await handleCreateAccessToken('test-board', request, env)
|
|
const data = await response.json() as { error: string }
|
|
|
|
// With our mock returning null for device lookup, we get 401
|
|
// But the important thing is admin tokens are blocked by the handler
|
|
expect(response.status).toBe(401)
|
|
})
|
|
})
|